Skip to content

DTLS: clear dtls_tx_msg cursor when its record is freed#10982

Merged
SparkiDev merged 1 commit into
wolfSSL:masterfrom
julek-wolfssl:dtls-clear-tx-cursor-on-free
Jul 24, 2026
Merged

DTLS: clear dtls_tx_msg cursor when its record is freed#10982
SparkiDev merged 1 commit into
wolfSSL:masterfrom
julek-wolfssl:dtls-clear-tx-cursor-on-free

Conversation

@julek-wolfssl

Copy link
Copy Markdown
Member

Summary

  • `DtlsTxMsgListClean()` could free the record pointed to by `ssl->dtls_tx_msg` without clearing the cursor, leaving a dangling pointer.

Test plan

  • `./commit-tests.sh`

@julek-wolfssl julek-wolfssl self-assigned this Jul 23, 2026
Copilot AI review requested due to automatic review settings July 23, 2026 10:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a DTLS state management issue where DtlsTxMsgListClean() could free a transmit message record without clearing ssl->dtls_tx_msg, potentially leaving a dangling cursor pointer used by retransmission logic.

Changes:

  • Clear ssl->dtls_tx_msg when it points to a DtlsMsg record that is being deleted during TX message list cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@julek-wolfssl
julek-wolfssl marked this pull request as ready for review July 23, 2026 11:24
@github-actions

Copy link
Copy Markdown

retest this please

@julek-wolfssl
julek-wolfssl force-pushed the dtls-clear-tx-cursor-on-free branch from cf68bbb to 9d2b32e Compare July 23, 2026 14:07
@SparkiDev
SparkiDev requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot July 24, 2026 00:46

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10982

Scan targets checked: wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@SparkiDev
SparkiDev merged commit f5ace71 into wolfSSL:master Jul 24, 2026
362 of 363 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants